Repository navigation
Conversation
ziy00n
commented
May 24, 2023
ziy00n
commented
Contributor
plum-king
requested changes
May 27, 2023
plum-king
left a comment
plum-king
left a comment
Contributor
There was a problem hiding this comment.
적록색약의 경우, 대부분 잘 풀어주신 것 같은데 일부 수정이 필요하여 리뷰 달아두었습니다. 범위는 모두 n으로 맞춰주시고 if문 하나 더 추가하셔야 되는 부분까지 수정해주시면 답 제대로 출력될 것 같아요! n단 논법도 플로이드 알고리즘 잘 사용하셔서 풀어주신 것 같습니다!! 3중 for문이 돌아가는 횟수도 잘 넣어주신 것 같아요! 문제 푸시느라 고생하셨습니다 :)
Comment on lines
16
to
17
Contributor
There was a problem hiding this comment.
graph = [list(input().rstrip()) for _ in range(n)]
이런 식으로 범위를 n+1 말고 n으로 수정해주시면 될 것 같아요! 아래에서 for문 돌 때도 마찬가지로 범위를 n으로 맞춰서 수정해주시면 될 것 같아요!
Comment on lines
43
to
45
Contributor
There was a problem hiding this comment.
if (n > newX >= 0) and (n > newY >= 0):
이 부분 추가해주셔서 newX와 newY에 대한 조건이 만족할 때만 해당 코드를 실행할 수 있도록 제어해주도록 수정하시면 좋을 것 같아요!
Comment on lines
58
to
59
plum-king
approved these changes
Jun 8, 2023
plum-king
left a comment
plum-king
left a comment
Contributor
There was a problem hiding this comment.
랜선 자르기는 배운 이분 탐색 내용 잘 사용해서 풀어주신 것 같고, 회의실 배정은 그리디 알고리즘의 개념 사용해서 잘 풀어주신 것 같아요! 문제 푸시느라 고생하셨습니다 :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.